FSFE-defined coding standards?

Valerio Bellizzomi valerio at selnet.org
Wed Feb 10 08:13:35 UTC 2021


On Tue, 2021-02-09 at 22:40 +0100, Eike Rathke wrote:
> Hi,
> 
> On Monday, 2021-02-08 10:56:43 +0000, Jacob Hrbek wrote:
> 
> > Should FSFE provide some kind of platform for community to discuss
> > and propose coding standards?
> 
> Before discussing coding standards we should rule out bad Mail User
> Agents that produce totally unusable text/plain from text/html in
> their
> multipart/alternative:

I don't consider those Mail User Agents as bad, producing text/plain
from text/html is a security feature in some mail clients, for example
in Evolution.


> > Bad code:
> > 
> > #!/bin/bash
> > 
> > number=
> > 
> > "5"
> > 
> > if
> > 
> > [[
> > 
> > "
> > 
> > $number
> > 
> > "
> > 
> > =~ [0-9] ]];
> > 
> > then
> > 
> > whatever;
> > 
> > fi
> > 
> > - Works only on systems with dynamic linking
> > - Bash is not part of standard portable OS → Not portable
> > 
> > Good code:
> > 
> > #!/bin/sh
> > 
> > # shellcheck shell=sh # Written to comply with IEEE Std 1003.1-2017
> > [<
> > http://get.posixcertified.ieee.org/>](http://get.posixcertified.ieee.org/
> > )
> > number=
> > 
> > "5"
> > 
> > case
> > 
> > "
> > 
> > $number
> > 
> > "
> > 
> > in
> > 
> > [0-9]) whatever;
> > 
> > esac
> 
> As sent, both are bad code.
> 
>   Eike
> 
> _______________________________________________
> Discussion mailing list
> Discussion at lists.fsfe.org
> https://lists.fsfe.org/mailman/listinfo/discussion
> 
> This mailing list is covered by the FSFE's Code of Conduct. All
> participants are kindly asked to be excellent to each other:
> https://fsfe.org/about/codeofconduct



More information about the Discussion mailing list