Dear webmasters,
it seems that in the Wiki's CSS, any first-level heading does a clear:both, but a second-level heading doesn't.
I think any heading should cause a clear:both, so pages like https://wiki.fsfe.org/KnowHow/Groups/OrganizeABooth/BoothDesign (see the "Examples" section) look better.
I've already received confirmation from the wiki caretakers team that they approve of this change, and was told that the ones actually doing the change would be the webmasters.
Thanks,
Hi Reinhard,
~ Reinhard Müller [2020-03-13 12:53 +0100]:
I've already received confirmation from the wiki caretakers team that they approve of this change, and was told that the ones actually doing the change would be the webmasters.
I am sorry to start a "not my responsibility" game here, but it's new to me that web@ does CSS changes for the wiki. The CSS file for wiki.fsfe.org is stored solely on the wiki server (scheele) and therefore can only be updated by those who have access to it.
As System Administrator, I personally have access to the server, so in order to avoid a further back and forth you can send me the changed file (or a diff if you prefer).
Best, Max
Make sure to keep the changes tracked within https://git.fsfe.org/fsfe-wiki/wiki-setup/src/branch/master/mointheme_fsfe
Keeping lower level headings within the floatable textbody was intentional in the original CSS to prevent empty spaces next to single images.
Hi Max,
On Freitag, 13. März 2020 13:00:33 CET Max Mehl wrote:
I am sorry to start a "not my responsibility" game here, but it's new to me that web@ does CSS changes for the wiki. The CSS file for wiki.fsfe.org is stored solely on the wiki server (scheele) and therefore can only be updated by those who have access to it.
I think it's not so much a responsibility thing, but rather a question of domain knowledge. As a wiki caretaker I'm not really knowledgeable about CSS issues. I pointed Reinhard to web@ because there can be a technical discussion about any proposed changes here.
As System Administrator, I personally have access to the server, so in order to avoid a further back and forth you can send me the changed file (or a diff if you prefer).
Thanks for the offer! Once the change in CSS is implemented, Thomas or I can put the file there as well...
Cheers, Johannes
Hi, Max!
Am 13.03.20 um 13:00 schrieb Max Mehl:
As System Administrator, I personally have access to the server, so in order to avoid a further back and forth you can send me the changed file (or a diff if you prefer).
Thank you very much! Please find the updated file attached, there's only one line changed. I tried to create a pull request on the git repository that Paul mentioned, but I was told that "This repo is archived. You can view files and clone it, but cannot push or open issues/pull-requests."
Thanks,
~ Reinhard Müller [2020-03-16 09:47 +0100]:
Am 13.03.20 um 13:00 schrieb Max Mehl:
As System Administrator, I personally have access to the server, so in order to avoid a further back and forth you can send me the changed file (or a diff if you prefer).
Thank you very much! Please find the updated file attached, there's only one line changed.
Thank you, copied on the server.
I tried to create a pull request on the git repository that Paul mentioned, but I was told that "This repo is archived. You can view files and clone it, but cannot push or open issues/pull-requests."
Yes, the repo has not been used so it has been archived. However, to allow for more collaboration, it could easily be reactivated and deployed automatically, e.g. via Drone or a cronjob running "git pull" on the server or so.
Best, Max
Hi,
Am 16.03.20 um 11:06 schrieb Max Mehl:
Thank you very much! Please find the updated file attached, there's only one line changed.
Thank you, copied on the server.
I just checked the page in question, and it looks very good now. Thank you again, issue closed :-)
Best,